Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No completions in comments #1999

Merged
merged 1 commit into from
Nov 1, 2024
Merged

No completions in comments #1999

merged 1 commit into from
Nov 1, 2024

Conversation

minestarks
Copy link
Member

@minestarks minestarks commented Nov 1, 2024 •
edited
Loading

Suppress completions inside comments like

import Foo;
// Hello there |
import Bar;

orpuente-MS
orpuente-MS approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@orpuente-MS orpuente-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving. I think this solution is good enough for now, but I guess merging depends on general consensus.

@minestarks minestarks added this pull request to the merge queue Nov 1, 2024
@minestarks minestarks mentioned this pull request Nov 1, 2024
Open
@minestarks
Copy link
Member Author

minestarks commented Nov 1, 2024 •
edited
Loading

Created #2000 for followup

Merged via the queue into main with commit b700869 Nov 1, 2024
18 checks passed
@minestarks minestarks deleted the minestarks/no-completions-in-comments branch November 1, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmitryVasilevsky DmitryVasilevsky DmitryVasilevsky left review comments

@swernli swernli swernli left review comments

@billti billti billti left review comments

@orpuente-MS orpuente-MS orpuente-MS approved these changes

@idavis idavis idavis approved these changes

@ScottCarda-MS ScottCarda-MS Awaiting requested review from ScottCarda-MS ScottCarda-MS is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@minestarks @idavis @billti @swernli @DmitryVasilevsky @orpuente-MS