Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TwoPaneView type information not available to app code #36

Open
kmelmon opened this issue May 18, 2020 · 0 comments
Open

TwoPaneView type information not available to app code #36

kmelmon opened this issue May 18, 2020 · 0 comments
Labels
bug Something isn't working TwoPaneView

Comments

@kmelmon
Copy link
Contributor

kmelmon commented May 18, 2020

Something isn't correct with the way TwoPaneView Typescript type information is being published. This results in a runtime error if you try to use the type information.

For example:
<TwoPaneView paneMode = {PaneMode.Auto}>
doesn't work.

For now you can do this instead:
<TwoPaneView paneMode = 'Auto'>

Interestingly we did something similar for types in react-native-dualscreeninfo, but those types are working correctly. We just need to study how types.d.ts is being authored/built/published.

@ghost ghost added the Needs: triage 🔍 label May 18, 2020
@chrisglein chrisglein added bug Something isn't working TwoPaneView and removed Needs: triage 🔍 labels Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working TwoPaneView
Projects
None yet
Development

No branches or pull requests

2 participants