Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document dualscreeninfo deviceOrientation property #41

Open
kmelmon opened this issue May 19, 2020 · 0 comments
Open

Document dualscreeninfo deviceOrientation property #41

kmelmon opened this issue May 19, 2020 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@kmelmon
Copy link
Contributor

kmelmon commented May 19, 2020 •
edited
Loading

This PR introduced a new prop for react-native-dualscreeninfo:
#34

The prop is DualScreenInfo.orientation

It has values from the below enum:

export enum DeviceOrientation {
Portrait = 'portrait',
Landscape = 'landscape',
PortraitFlipped = 'portraitFlipped',
LandscapeFlipped = 'landscapeFlipped',
};

We should update the spec with this prop.
@ghost ghost added the Needs: triage 🔍 label May 19, 2020
@chrisglein chrisglein added documentation Improvements or additions to documentation enhancement New feature or request and removed Needs: triage 🔍 labels Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kikisaints @chrisglein @kmelmon