From a406ab2b20d8fb5d277c2f060993c72cb74efc91 Mon Sep 17 00:00:00 2001 From: Shawn Dempsey Date: Fri, 10 Feb 2023 15:36:32 -0800 Subject: [PATCH 1/2] Don't passthru key events that override Pressibilty api's --- Libraries/Components/Touchable/TouchableWithoutFeedback.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Libraries/Components/Touchable/TouchableWithoutFeedback.js b/Libraries/Components/Touchable/TouchableWithoutFeedback.js index dd294b519cd1bb..7ee994b65a9a2a 100755 --- a/Libraries/Components/Touchable/TouchableWithoutFeedback.js +++ b/Libraries/Components/Touchable/TouchableWithoutFeedback.js @@ -105,8 +105,8 @@ const PASSTHROUGH_PROPS = [ 'onAccessibilityAction', 'onBlur', 'onFocus', - 'onKeyDown', - 'onKeyUp', + // 'onKeyDown', // [macOS] + // 'onKeyUp', // [macOS] 'validKeysDown', 'validKeysUp', 'onLayout', From 0027e27665ba11e208abcfee52066f64654a111d Mon Sep 17 00:00:00 2001 From: Shawn Dempsey Date: Mon, 13 Feb 2023 12:58:16 -0800 Subject: [PATCH 2/2] Remove key callbacks instead of commenting out --- Libraries/Components/Touchable/TouchableWithoutFeedback.js | 2 -- 1 file changed, 2 deletions(-) diff --git a/Libraries/Components/Touchable/TouchableWithoutFeedback.js b/Libraries/Components/Touchable/TouchableWithoutFeedback.js index 7ee994b65a9a2a..86e03913e4a0f2 100755 --- a/Libraries/Components/Touchable/TouchableWithoutFeedback.js +++ b/Libraries/Components/Touchable/TouchableWithoutFeedback.js @@ -105,8 +105,6 @@ const PASSTHROUGH_PROPS = [ 'onAccessibilityAction', 'onBlur', 'onFocus', - // 'onKeyDown', // [macOS] - // 'onKeyUp', // [macOS] 'validKeysDown', 'validKeysUp', 'onLayout',