Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new app / lib templates should help prevent checking in msbuild binlog files #14160

Open
jonthysell opened this issue Dec 4, 2024 · 1 comment
Labels
Area: App Template Area: Library Template enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: New Arch Soft Launch Soft launch the new architecture in 0.76.
Milestone

Comments

@jonthysell
Copy link
Contributor

Summary

  1. The init-windows for the new templates should inject *.binlog into the project root .gitignore if the ignore file exists (and the line doesn't exist)
  2. (Optional): We shouldn't dump the binlog to the root folder, maybe we could put it somewhere else (maybe the windows folder, where it's easier for us to gitignore it) and then output the path to the log file at the end of the command.

Motivation

Right now, if you run run-windows --logging you'll get an msbuild.binlog file in the root of your project file (where you run run-windows 99% of the time). This file risks being checked in accidentally.

Basic Example

No response

Open Questions

No response

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Dec 4, 2024
@chrisglein
Copy link
Member

Related: #5937
Issue there was the binlog getting dropped in the root and having different rules for what the gitignore could do. Moving where it got dropped would help.

@chrisglein chrisglein added Area: App Template New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Area: Library Template Workstream: New Arch Soft Launch Soft launch the new architecture in 0.76. and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Dec 9, 2024
@chrisglein chrisglein added this to the Backlog milestone Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: App Template Area: Library Template enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric Workstream: New Arch Soft Launch Soft launch the new architecture in 0.76.
Projects
None yet
Development

No branches or pull requests

2 participants