Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize ViewComponent builder overrides #14174

Open
acoates-ms opened this issue Dec 6, 2024 · 0 comments
Open

Optimize ViewComponent builder overrides #14174

acoates-ms opened this issue Dec 6, 2024 · 0 comments
Assignees
@acoates-ms
Labels
Area: Performance enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Milestone
Next

Comments

@acoates-ms
Copy link
Contributor

As the number of overrides expands in ViewComponentView, we are currently adding additional members for each override. Instead we should have a pointer to the builder, or some similar vtable object that can be shared across all components of that type, and reduce the memory footprint of each ViewComponentView.
@acoates-ms acoates-ms self-assigned this Dec 6, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Dec 6, 2024
@acoates-ms acoates-ms mentioned this issue Dec 9, 2024
Merged
@chrisglein chrisglein added this to the Next milestone Dec 9, 2024
@chrisglein chrisglein added enhancement Area: Performance New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acoates-ms acoates-ms

Labels
Area: Performance enhancement New Architecture Broad category for issues that apply to the RN "new" architecture of Turbo Modules + Fabric
Projects
None yet
Milestone
Next
Development

No branches or pull requests
2 participants
@chrisglein @acoates-ms