Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add utf16 to JSI #14185

Open
TatianaKapos opened this issue Dec 9, 2024 · 0 comments
Open

Add utf16 to JSI #14185

TatianaKapos opened this issue Dec 9, 2024 · 0 comments
Assignees
@vmoroz
Labels
Area: JSI Integration Follow-up Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot)
Milestone
0.77

Comments

@TatianaKapos
Copy link
Contributor

Problem Description

Recent integration brings in facebook/react-native#47356 which we need to update the JSI files in our repo and Hermes-windows repo to add utf16 method. Since this isn't being used in any code yet, I was able to just disable to test to get the integration building!

There were also these two PRs in the integration that may need to be pulled into the hermes-repo: facebook/react-native#47331 and facebook/react-native#47422

Link to the integration where the error originated

#14167

Link to commit

facebook/react-native#47356
facebook/react-native#47331
facebook/react-native#47422

Forked files

  1. testlib.cpp

Upstream PR

No response

Build Configuration

None
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Dec 9, 2024
@TatianaKapos TatianaKapos changed the title Add utf16 ti JSI Add utf16 to JSI Dec 9, 2024
@TatianaKapos TatianaKapos mentioned this issue Dec 9, 2024
Merged
@jonthysell jonthysell added Area: JSI and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Dec 12, 2024
@jonthysell jonthysell added this to the 0.77 milestone Dec 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot) label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vmoroz vmoroz

Labels
Area: JSI Integration Follow-up Invalid Triage https://github.com/microsoft/react-native-windows/wiki/Triage-Process (label applied by bot)
Projects
None yet
Milestone
0.77
Development

No branches or pull requests
3 participants
@vmoroz @jonthysell @TatianaKapos