Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task not working as expected #112

Open
SagarKalankar opened this issue May 20, 2024 · 5 comments
Open

Task not working as expected #112

SagarKalankar opened this issue May 20, 2024 · 5 comments

Comments

@SagarKalankar
Copy link

SagarKalankar commented May 20, 2024

No description provided.

@chrisnielsen-MS
Copy link
Contributor

Hi @SagarKalankar, I tried to reproduce this in my own pipeline but was unable to get the same behavior. Can you share your task logs to help me pinpoint what is going on with your build? A Debug Drop would be even better if you are able to share it.

@SagarKalankar
Copy link
Author

SagarKalankar commented May 21, 2024

@chrisnielsen-MS
Copy link
Contributor

chrisnielsen-MS commented May 22, 2024

I see what I was missing the first time -- my original test pipeline was set up to use policy: none while yours is using the default policy. It looks like the policy is currently not working properly for Trivy and overrides all of the rule severities to "warning". There are a couple workarounds you can use until we can update our policy for this:

1.) You can run without any policy. This will also turn off the auto-applicability, so you will need to specify all the tools you want to run in your yaml like your provided sample. To do this, just add "policy: none" to the task inputs in your yaml.

2.) You can override the break level. This is probably too aggressive for breaking the pipeline, but it is another way to get the breaks. It will cause the pipeline to break for any trivy findings, though. To do this, add one more env variable to your yaml:
GDN_RUN_MINSEVERITY: 'warning'

@SagarKalankar SagarKalankar changed the title Trivy Image scan not getting break when finding a HIGH vulnerability Trivy Image scan May 24, 2024
@SagarKalankar SagarKalankar changed the title Trivy Image scan Task not working as expected May 27, 2024
@SagarKalankar
Copy link
Author

Thank you for the support. I am able to now break the pipeline for HIGH or CRITICAL issues (with the use of break) by setting policy to 'none'.

@reynoldsa
Copy link
Contributor

@SagarKalankar this should be fixed - please try again with policy and let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants