Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update check logic leaves Octory in limbo #88

Open
arlogilbert opened this issue Dec 28, 2022 · 0 comments
Open

Update check logic leaves Octory in limbo #88

arlogilbert opened this issue Dec 28, 2022 · 0 comments

Comments

@arlogilbert
Copy link

On line 373-377 in your app installer scripts for mac where it says

    # App is installed, if it's updates are handled by MAU we should quietly exit
    if [[ $autoUpdate == "true" ]]; then
        echo "$(date) | [$appname] is already installed and handles updates itself, exiting"
        exit 0;
    fi

You may want to insert a updateOctory installed just before the exit 0 - otherwise Octory will eternally wait for the install to kick off, which if an app is marked as mandatory and users can't quit without mandatory apps installing, could result in a user being effectively locked out of their machine (partly due to an Octory bug where the force quit keys don't work in blurred mode).

I'd submit a pull request but it's a lot of different files that need to be edited 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant