Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH actions tutorials - Install TorchGeo from checked out repo #2306

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

sfalkena
Copy link
Contributor

Currently, TorchGeo is installed by the first cell of the first notebook that is run. That installs the latest release of the repository, but fails to install the current version of the repo during PR's. Therefore, nbmake fails if both a feature and a tutorial notebook get added as part of a PR at the same time. This fix installs the checked out repository instead.

Fixes issues found by #2300 and #1897

@github-actions github-actions bot added the testing Continuous integration testing label Sep 20, 2024
Copy link
Collaborator

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the best 1-character PR I've ever seen. Can't believe we've been testing the latest release instead of the latest commit all this time. Thanks for the fix!

@adamjstewart adamjstewart merged commit 43d0d94 into microsoft:main Sep 20, 2024
19 checks passed
adamjstewart pushed a commit that referenced this pull request Oct 10, 2024
* Remove required.txt and install torchgeo from checked-out repo

* keep required.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Continuous integration testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants