Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gloo] build failure #36833

Closed
Bzz2745 opened this issue Feb 18, 2024 · 5 comments · Fixed by #36988
Closed

[gloo] build failure #36833

Bzz2745 opened this issue Feb 18, 2024 · 5 comments · Fixed by #36988
Assignees
Labels
requires:repro The issue is not currently repro-able Stale

Comments

@Bzz2745
Copy link

Bzz2745 commented Feb 18, 2024

Operating system

Linux

Compiler

gcc-12 cuda-12

Steps to reproduce the behavior

`vcpkg install gloo`

Failure logs

Computing installation plan...
The following packages will be built and installed:
gloo:x64-linux@20201203#2
Installing 1/1 gloo:x64-linux@20201203#2...
Building gloo:x64-linux@20201203#2...
-- Using cached facebookincubator-gloo-1da21174054eaabbbd189b7f657ea24842d821e2.tar.gz.
-- Extracting source /home/user/Environments/vcpkg/downloads/facebookincubator-gloo-1da21174054eaabbbd189b7f657ea24842d821e2.tar.gz
-- Using source at /home/user/Environments/vcpkg/buildtrees/gloo/src/4842d821e2-089f9c85b8
-- Configuring x64-linux
-- Building x64-linux-dbg
CMake Error at scripts/cmake/vcpkg_execute_build_process.cmake:134 (message):
Command failed: /home/user/Environments/vcpkg/downloads/tools/cmake-3.27.1-linux/cmake-3.27.1-linux-x86_64/bin/cmake --build . --config Debug --target install -- -v -j13
Working Directory: /home/user/Environments/vcpkg/buildtrees/gloo/x64-linux-dbg
See logs for more information:
/home/user/Environments/vcpkg/buildtrees/gloo/install-x64-linux-dbg-out.log

Call Stack (most recent call first):
installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_build.cmake:74 (vcpkg_execute_build_process)
installed/x64-linux/share/vcpkg-cmake/vcpkg_cmake_install.cmake:16 (vcpkg_cmake_build)
ports/gloo/portfile.cmake:25 (vcpkg_cmake_install)
scripts/ports.cmake:170 (include)

Additional context

install-x64-linux-dbg-out.log

I have tried the solution provided by this link but not work , here is other link might help (but I didn't find the obvious way to solve it) :

https://www.mail-archive.com/[email protected]/msg1875386.html

@facebookincubator/gloo#345

@facebookincubator/gloo#346

@facebookincubator/gloo@1090929

@Bzz2745 Bzz2745 added the category:port-bug The issue is with a library, which is something the port should already support label Feb 18, 2024
@MonicaLiu0311
Copy link
Contributor

It worked when I installed using gcc-11. When I installed using gcc-12, I got a different error than yours:

[31/37] /usr/bin/c++  -I/mnt/vcpkg/buildtrees/gloo/src/4842d821e2-089f9c85b8.clean -I/mnt/vcpkg/buildtrees/gloo/x64-linux-dbg -fPIC -std=c++11 -fPIC -g -MD -MT gloo/CMakeFiles/gloo.dir/transport/tcp/device.cc.o -MF gloo/CMakeFiles/gloo.dir/transport/tcp/device.cc.o.d -o gloo/CMakeFiles/gloo.dir/transport/tcp/device.cc.o -c /mnt/vcpkg/buildtrees/gloo/src/4842d821e2-089f9c85b8.clean/gloo/transport/tcp/device.cc
FAILED: gloo/CMakeFiles/gloo.dir/transport/tcp/device.cc.o
/usr/bin/c++  -I/mnt/vcpkg/buildtrees/gloo/src/4842d821e2-089f9c85b8.clean -I/mnt/vcpkg/buildtrees/gloo/x64-linux-dbg -fPIC -std=c++11 -fPIC -g -MD -MT gloo/CMakeFiles/gloo.dir/transport/tcp/device.cc.o -MF gloo/CMakeFiles/gloo.dir/transport/tcp/device.cc.o.d -o gloo/CMakeFiles/gloo.dir/transport/tcp/device.cc.o -c /mnt/vcpkg/buildtrees/gloo/src/4842d821e2-089f9c85b8.clean/gloo/transport/tcp/device.cc
/mnt/vcpkg/buildtrees/gloo/src/4842d821e2-089f9c85b8.clean/gloo/transport/tcp/device.cc: In function ‘gloo::transport::tcp::attr gloo::transport::tcp::CreateDeviceAttr(const attr&)’:
/mnt/vcpkg/buildtrees/gloo/src/4842d821e2-089f9c85b8.clean/gloo/transport/tcp/device.cc:151:39: error: aggregate ‘std::array<char, 64> hostname’ has incomplete type and cannot be defined
  151 |       std::array<char, HOST_NAME_MAX> hostname;
      |                                       ^~~~~~~~

vicroms pushed a commit that referenced this issue Feb 29, 2024
Fixes #36833
```
/mnt/vcpkg/buildtrees/gloo/src/4842d821e2-089f9c85b8.clean/gloo/transport/tcp/device.cc:151:39: error: aggregate ‘std::array<char, 64> hostname’ has incomplete type and cannot be defined
  151 |       std::array<char, HOST_NAME_MAX> hostname;
      |                                       ^~~~~~~~
```
- [X] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [ ] ~~SHA512s are updated for each updated download.~~
- [ ] ~~The "supports" clause reflects platforms that may be fixed by
this new version.~~
- [ ] ~~Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.~~
- [ ] ~~Any patches that are no longer applied are deleted from the
port's directory.~~
- [X] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [X] Only one version is added to each modified port's versions file.

Usage test pass with following triplets:

```
x64-linux
```
@Bzz2745
Copy link
Author

Bzz2745 commented Mar 2, 2024

Unfortunately, it still doesn't work properly now. This is the new log file I generated when I used vcpkg to compile gloo:
install-x64-linux-dbg-out.log

@MonicaLiu0311
Copy link
Contributor

We cannot repro your issue, but we have found a similar fix upstream. Could you please try to see if it solves your current problem: facebookincubator/gloo#352.

@MonicaLiu0311 MonicaLiu0311 reopened this Mar 4, 2024
@MonicaLiu0311 MonicaLiu0311 added requires:repro The issue is not currently repro-able and removed category:port-bug The issue is with a library, which is something the port should already support labels Mar 4, 2024
@jimwang118
Copy link
Contributor

Unfortunately, it still doesn't work properly now. This is the new log file I generated when I used vcpkg to compile gloo: install-x64-linux-dbg-out.log

I cannot reproduce your problem locally. Is the system you are using Ubuntu, Redhat or centos?
You can try using the PR code below to see if it can fix your problem.

Copy link

github-actions bot commented Apr 2, 2024

This is an automated message. Per our repo policy, stale issues get closed if there has been no activity in the past 28 days. The issue will be automatically closed in 14 days. If you wish to keep this issue open, please add a new comment.

@github-actions github-actions bot added the Stale label Apr 2, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires:repro The issue is not currently repro-able Stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants