-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libavif] Remove incorrect CMake config #42151
base: master
Are you sure you want to change the base?
[libavif] Remove incorrect CMake config #42151
Conversation
5ab3d06
to
9a2b8a5
Compare
@WangWeiLin-MV Does this also work with the |
@jdpurcell Could you help provide a minimal test source code? |
@WangWeiLin-MV It's the same code from #42112 that simply prints the version. The build fails with errors like:
|
It builds pass and print Could you append the build command with CMake? |
@WangWeiLin-MV Test with static library linkage and |
@WangWeiLin-MV I reproduced it on Windows with: test-libavif.zip I opened
Last command failed with:
|
Thanks, it reproduced. |
The CMake config file seem not working, I will check the source code of this project later. Please use the pc file: find_package(PkgConfig)
pkg_check_modules(libavif REQUIRED IMPORTED_TARGET libavif)
target_link_libraries(main PRIVATE PkgConfig::libavif) |
9b6b5b5
to
c0339dd
Compare
c0339dd
to
a3ee7fc
Compare
a3ee7fc
to
9587de1
Compare
Related #42112, error with
fatal error: 'avif/avif.h' file not found
that targetiavif
lostINTERFACE_INCLUDE_DIRECTORIES
for static build.Upstream CMake config file does not work since features (dependencies) added 927bc12. Adding transitive dependencies cannot be fixed it, so remove it from usage prompt.
Checklist
SHA512s are updated for each updated download.The "supports" clause reflects platforms that may be fixed by this new version.Any fixed CI baseline entries are removed from that file.Any patches that are no longer applied are deleted from the port's directory../vcpkg x-add-version --all
and committing the result.Test
The port usage tests pass with the following triplets: