Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serviceconnector: Add "Create connection" and "Delete connection" activity children #1577

Merged
merged 2 commits into from
Sep 1, 2023
Merged

serviceconnector: Add "Create connection" and "Delete connection" activity children #1577

merged 2 commits into from
Sep 1, 2023

Conversation

motm32
Copy link
Contributor

@motm32 motm32 commented Sep 1, 2023

Add activity children that displays the name of the application settings added:
image

@motm32 motm32 requested a review from a team as a code owner September 1, 2023 22:37
alexweininger
alexweininger approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@alexweininger alexweininger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do "App setting" like the portal does instead of "application setting"
image

@motm32
Copy link
Contributor Author

motm32 commented Sep 1, 2023

We can do "App setting" like the portal does instead of "application setting" image

I don't mind that just named it application settings since thats what the tree node is called
image

@alexweininger
Copy link
Member

We can do "App setting" like the portal does instead of "application setting" image

I don't mind that just named it application settings since thats what the tree node is called image

Ya ignore me. Keep it as it is.

@motm32 motm32 merged commit 9ee913c into main Sep 1, 2023
4 checks passed
@motm32 motm32 deleted the meganmott/addCreateChildren branch September 1, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexweininger alexweininger alexweininger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@motm32 @alexweininger