serviceconnector: Add database subtypes #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
reviewed
Sep 8, 2023
| @@ -43,7 +47,19 @@ export class TargetServiceListStep extends AzureWizardPromptStep<ICreateLinkerCo | |||
| case TargetServiceTypeName.Storage: | |||
| promptSteps.push(new StorageAccountListStep(storageAccountCreateOptions)); | |||
| break; | |||
| case TargetServiceTypeName.CosmosDB: | |||
| case TargetServiceTypeName.Cassandra: | |||
There was a problem hiding this comment.
It might make more sense for the switch case to check the group. That shouldn't change anything for Storage (since all of the groups are also TargetServiceTypeName.Storage).
But it'd make this a lot cleaner since all are part of TargetServiceTypeName.CosmosDB and are all using the same promptStep as far as I can tell.
There was a problem hiding this comment.
Very true I will do that!
nturinski
reviewed
Sep 13, 2023
| { label: vscode.l10n.t('NoSQL'), data: { name: "sql", type: TargetServiceTypeName.NoSQL, id: '/databases' }, group: TargetServiceTypeName.CosmosDB }, | ||
| { label: vscode.l10n.t('Table'), data: { name: "table", type: TargetServiceTypeName.Table, id: '/databases' }, group: TargetServiceTypeName.CosmosDB }, | ||
| { label: vscode.l10n.t('Key Vault'), data: { name: "keyVault", type: TargetServiceTypeName.KeyVault, id: '/keyVault' }, group: TargetServiceTypeName.KeyVault }, | ||
| { label: vscode.l10n.t('Blob'), data: { name: "storageBlob", type: TargetServiceTypeName.Storage, id: '/blobServices/default', group: TargetServiceTypeName.Storage }, group: TargetServiceTypeName.Storage }, |
There was a problem hiding this comment.
Heh, this is a little bit goofy. It definitely works, but the repeat code hurts my eyes 😭
Could I suggest that rather than duplicating the group property in data, that you instead save the result of the quickPick item instead of just the data?
Something like this
const result = await context.ui.showQuickPick(picks, { placeHolder, enableGrouping: true };
context.targetServiceType = result.data;
switch (result.group) {
...
…ganmott/addDatabaseSubTypes
nturinski
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in database subtypes and filter the database accounts based on the chosen type. Here is how the new list looks:
