serviceconnector: Change nonNullValue to nonNullProp
#1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
reviewed
Sep 13, 2023
| import * as vscode from 'vscode'; | ||
| import { ICreateLinkerContext } from './ICreateLinkerContext'; | ||
|
|
||
| export class LinkerNameStep extends AzureWizardPromptStep<ICreateLinkerContext>{ | ||
| public async prompt(context: ICreateLinkerContext): Promise<void> { | ||
| context.linkerName = await context.ui.showInputBox({ | ||
| prompt: vscode.l10n.t('Enter a name for the connection'), | ||
| value: nonNullValue(context.targetServiceType?.name) + '_' + randomUtils.getRandomHexString(5), | ||
| value: nonNullProp(nonNullProp(context, 'targetServiceType'), 'name') + '_' + randomUtils.getRandomHexString(5), |
There was a problem hiding this comment.
I think you can use nonNullPropAndValue here as well, but this fine as well.
nturinski
reviewed
Sep 13, 2023
| return linkers.map(linker => createServiceConnectorItem(this.subscription, this.item, linker)); | ||
| }); | ||
|
|
||
| return nonNullValue(result); | ||
| return nonNullValue(result, 'getChildren'); |
There was a problem hiding this comment.
I don't understand this change here.
There was a problem hiding this comment.
I added 'getChildren' as a propertyNameOrMessage since I still wanted to have some context as to what value is nonNull. I couldn't change this to nonNullProp since result isn't a property. Not sure if this is actually what this optional parameter does since it doesn't give a description.
nturinski
previously approved these changes
Sep 13, 2023
nturinski
previously approved these changes
Sep 19, 2023
nturinski
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing so error messages are more detailed.