Warn people to not use id containing '+' for AzExtTreeFileSystem items #1588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonYeMSFT
force-pushed
the
dev/chuye/break-AzExtTreeFileSystem
branch
from
f4a6cdf to
d76cb45
Compare
JasonYeMSFT
changed the title
nturinski
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR had something to do with microsoft/vscode-cosmosdb#1732
The root cause of the problem is the plus sign '+'. Encoding and decoding the '+' will make it replaced by whitespace due to the query string standard. I added a comment in the interface to warn people to not use anything that may contain + sign in the id for File System items.
Related discussions:
https://stackoverflow.com/questions/1634271/url-encoding-the-space-character-or-20
https://www.w3.org/TR/html4/interact/forms.html#h-17.13.4.1