Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

auth: Add enhanced tenant support #1590

Merged
merged 3 commits into from
Sep 19, 2023
Merged

auth: Add enhanced tenant support #1590

merged 3 commits into from
Sep 19, 2023

Conversation

alexweininger
Copy link
Member

API changes:

  • Make the getTenants function public
  • Add tenantId parameter to the signIn function to enable signing in to a specific tenant
  • Expose the tenantId parameter to the isSignedIn function (was already implemented, just not exposed)

I also am using cross-fetch to list the tenants because the SDK uses a very old API version that doesn't retrieve the full tenant object.

I will update the readme once the API changes are reviewed.

@alexweininger alexweininger requested a review from a team as a code owner September 19, 2023 16:28
bwateratmsft
bwateratmsft previously approved these changes Sep 19, 2023
View reviewed changes
@alexweininger alexweininger merged commit 288cc05 into main Sep 19, 2023
4 checks passed
@alexweininger alexweininger deleted the alex/moccasin-panda branch September 19, 2023 17:02
@bwateratmsft bwateratmsft mentioned this pull request Nov 20, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwateratmsft bwateratmsft bwateratmsft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexweininger @bwateratmsft