appservice: Use vscode.workspace.findFiles rather than globby to get files to zip #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nturinski
changed the title
nturinski
commented
Oct 30, 2023
| async function getFilesFromGlob(folderPath: string, site: ParsedSite): Promise<string[]> { | ||
| const zipDeployConfig: vscode.WorkspaceConfiguration = vscode.workspace.getConfiguration(ext.prefix, vscode.Uri.file(folderPath)); | ||
| const globOptions = { cwd: folderPath, followSymbolicLinks: true, dot: true }; | ||
| export async function getFilesFromGlob(folderPath: string, resourceName: string): Promise<string[]> { |
There was a problem hiding this comment.
A lot of this weird new logics is because a lot of these previous assumptions will break the appservice package when running the tests.
bwateratmsft
previously approved these changes
Oct 30, 2023
alexweininger
previously approved these changes
Oct 30, 2023
nturinski
dismissed stale reviews from alexweininger and bwateratmsft
via
d57745a
bwateratmsft
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support the weird blob patterns array that we have in App Service, I had to do some weird stuff because it's not trivial (at least, I couldn't easily figure it out) how to combine multiple blob patterns that have embedded patterns in them.
See here for an example of what I mean: https://github.com/microsoft/vscode-azureappservice/wiki/Configuring-Zip-Deployment
globby would return everything in terms of relative paths, but vscode.workspace.findFiles gave the absolute, which is why I'm returning everything as a relative path so no changes would need to be made in runWithZipStream.
Another weird nuance is that workspace.findFiles looks for every file in every workspace that is currently opened. Since that is not behavior that we would want for deploying, I also filter out the results from other folders as well.I found out that I can use a RelativePattern instead of limit search results to a specific workspace so using that instead.