auth: Add a getSessionWithScopes to AzureAuthentication
#1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwateratmsft
previously approved these changes
Aug 6, 2024
auth/src/AzureAuthentication.ts
Outdated
| @@ -9,12 +9,19 @@ import type * as vscode from 'vscode'; | |||
| * Represents a means of obtaining authentication data for an Azure subscription. | |||
| */ | |||
| export interface AzureAuthentication { | |||
| /** | |||
| * Gets a VS Code authentication session for an Azure subscription. | |||
| * Always uses the default scope, `https://management.azure.com/.default/.default.` | |||
There was a problem hiding this comment.
Clarify here that it will respect the microsoft-sovereign-cloud.environment setting.
alexweininger
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getSessionwould always end up retrieving the session without a scope. When we tried to fix it via this PR, there ended up being a lot of scope issues specifically around deployment.However, the need for a scoped token has come up again and is a requirement for security work. The easiest workaround to all the brokenness was to just make a new function that retrieves a new session while leaving the old one version alone.
This will be called by the Resources extension so that the user will not need to log in again. Here's that PR https://github.com/microsoft/vscode-azureresourcegroups/compare/nat/scopedSessions?expand=1