utils & dev: Add fix for tests that fail due to having showLoadingPrompt set to true
#1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicroFish91
changed the title
showLoadingPrompt setshowLoadingPrompt set to true
MicroFish91
force-pushed
the
mwf/dark-lavender
branch
from
db609f1 to
f532a7d
Compare
alexweininger
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were seeing tests failing due to having
showLoadingPromptset to true. It appears that the loading pick'sonDidHidewas being triggered when running multiple tests back-to-back, which would then cause a cancel and a premature wizard exit.This new logic would add an
isTestingboolean that the wizard can check internally so that we can prevent an early cancel from being issued. This boolean would be automatically set each time we create a test action context.