Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "build in ACR" command to ACA extension #3873

Open
bwateratmsft opened this issue Mar 20, 2023 · 4 comments
Open

Move "build in ACR" command to ACA extension #3873

bwateratmsft opened this issue Mar 20, 2023 · 4 comments

Comments

@bwateratmsft
Copy link
Collaborator

The Azure Container Apps extension is soon adding a command to build images in ACR. Using this would allow us to remove several Azure packages as dependencies, improving load time and reducing bundle size.

TODO: do we want to remove the command entirely, or leave in a soft entry point like we currently have with "Deploy to ACA"?

@dbreshears
Copy link
Member

Will this require having an ACA dependency to simply deploy to ACR?

@bwateratmsft
Copy link
Collaborator Author

Will this require having an ACA dependency to simply deploy to ACR?

No, the only thing I'd like to move is the "Run as task in Azure" / "Build image in Azure" feature. Local build and push, along with the other ACR features (repo browser essentially) should definitely stay in the Docker extension.

@dbreshears dbreshears added this to the 1.26.0 milestone Mar 23, 2023
@alexyaang alexyaang self-assigned this Apr 5, 2023
@dbreshears
Copy link
Member

dbreshears commented Apr 19, 2023

Let's seperate this into an NPM package that ACA and other extensions can leverage

@dbreshears
Copy link
Member

Moving to future as ACA still requires the Docker extension for authenticating and getting subscription/registry information.

@alexyaang alexyaang removed their assignment Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants