Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sizing of results grid is incorrect #18289

Closed
kburtram opened this issue Oct 21, 2024 · 4 comments
Closed

Sizing of results grid is incorrect #18289

kburtram opened this issue Oct 21, 2024 · 4 comments

Comments

@kburtram
Copy link
Member

Steps to Reproduce:

  1. Run a query

Expected: Scollbars only show if needed, there are only two scrollbars when needed for multiple resultsets, the toolbar buttons are always visible.

Actual: Double scrollbars, and toolbar buttons are obsured.

Image

@kburtram
Copy link
Member Author

I merged the fix to release/1.25, which fixes the main issue here but there are a couple details we still need to address for Nov.

  1. The scrollbars are different widths on different platforms, causing extra padding on mac, which we should tighten-up.
  2. The boundary condition of when to adjust for the double-scrollbar, i.e., gridCount * MIN_GRID_HEIGHT >= availableHeight, is off by some pixels, causing the toolbar to be obscured within a narrow range while resizing.

@cssuh
Copy link
Member

cssuh commented Oct 22, 2024

Thanks @kburtram, I'll take it from here!

@dombarnes
Copy link

Not sure how related, but the ability to double click a column resize bar and it stretch to the maximum width needed seems to be gone. Since you can only stretch it to the width of the available width in the query results window, it makes resizing later columns very difficult.

@cssuh
Copy link
Member

cssuh commented Nov 13, 2024

Opened #18383 and #18382 for tracking remaining items

@cssuh cssuh closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants