Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

php 8 anon class methods with nullable returns messing up syntax highlighting #124381

Closed
bobmagicii opened this issue May 21, 2021 · 1 comment
Closed

php 8 anon class methods with nullable returns messing up syntax highlighting #124381

bobmagicii opened this issue May 21, 2021 · 1 comment
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug php PHP support issues upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@bobmagicii
Copy link

bobmagicii commented May 21, 2021 •
edited
Loading

Does this issue occur when all extensions are disabled?: yes

  • VS Code Version: 1.57.0-insider and some version prior that i was using for months.
  • OS Version: w10

methods with nullable returns in php 8 anonymous classes mess up the syntax highlighting for everything that happens after that. when discussing with others it was suggested this is vscode's problem who in turn should blame atom editor for some reason.

119047988-3a4eda80-b984-11eb-8ec1-f5832706f84b

119047997-3cb13480-b984-11eb-8570-45edfca88231
@roblourens roblourens mentioned this issue Jun 1, 2021
Open
@roblourens
Copy link
Member

Filed upstream atom/language-php#429. Seems that the newline in the function definition is not parsed correctly

@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug php PHP support issues upstream-issue-linked This is an upstream issue that has been reported upstream labels Jun 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug php PHP support issues upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@roblourens @bobmagicii