Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new powershell default keeps opening on startup despite having set the default back to cmd #132480

Closed
Pomax opened this issue Sep 6, 2021 · 5 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@Pomax
Copy link

Pomax commented Sep 6, 2021

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.60.0
  • OS Version: Win10 pro x64

Steps to Reproduce:

  1. ctrl-shift-p -> Terminal: selected default profile -> set "command prompt" as the default terminal to use (because powershell does not support cross-platform syntax like & chaining, making it utterly useless for cross-platform projects)
  2. make sure the workspace has a terminal open, and that it's a "command prompt" terminal.
  3. close VS code
  4. reopen VS code for the same dir/project
  5. VS code reopens with a powershell terminal instead of a "command prompt" terminal.

Rechecking the default terminal profile, it's still set to "command prompt", so this feels like a bug, especially given the next behaviour:

  1. click the powershell terminal
  2. type exit and hit enter
  3. the integrated terminal panel disappears
  4. ctrl-shift-` to open a new terminal
  5. the terminal panel is restored, with the new terminal opened being the expected "command prompt" terminal.
@IllusionMH
Copy link
Contributor

/duplicate of #132150 or #128763

@Pomax
Copy link
Author

Pomax commented Sep 6, 2021

@IllusionMH the second one is about remote workspaces, which doesn't apply here, and the first one appears to be a closed issue that concluded with a workaround, not a proper fix?

So as far as I can tell, this issue is not a duplicate, and highlights a bug that still needs fixing. The terminal window should not open a powershell instances if the profile default is not powershell.

@IllusionMH
Copy link
Contributor

IllusionMH commented Sep 6, 2021

Why workaround? First issue closed with commit to main branch as third action on it. It needs to be added to recovery build for stable release.
Second issue is basically same but found in Insiders before 1.60 and reproducible without remote.

@Pomax
Copy link
Author

Pomax commented Sep 6, 2021

ah. Missed that part, thanks.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

3 participants
@Pomax @IllusionMH and others