Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing workbench.web.main.css #234416

Closed
OCram85 opened this issue Nov 22, 2024 · 3 comments
Closed

Missing workbench.web.main.css #234416

OCram85 opened this issue Nov 22, 2024 · 3 comments
Assignees
@bpasero
Labels
info-needed Issue requires more information from poster

Comments

@OCram85
Copy link

OCram85 commented Nov 22, 2024

Does this issue occur when all extensions are disabled?: Yes

  • VS Code Version: 1.95
  • OS Version: Ubuntu 22.04 / VSCode integrated in docker container

Steps to Reproduce:

  • The PR esm - remove some AMD artefacts #229915 removed the workbenchworkbench.web.main.css which allowed users adding custom fonts
  • Whats the preferred approach for now? - Could't find any equivalent CSS files.
@vs-code-engineering VS Code Engineering
Copy link

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.95.3. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@OCram85 OCram85 changed the title Missing workbenchworkbench.web.main.css Missing workbench.web.main.css Nov 22, 2024
@aeschli aeschli assigned bpasero and unassigned aeschli Nov 27, 2024
@bpasero
Copy link
Member

bpasero commented Nov 27, 2024

The CSS is still there:

  • desktop: app/out/vs/workbench/workbench.desktop.main.css
  • web: out/vs/workbench/workbench.web.main.css

@bpasero bpasero added the info-needed Issue requires more information from poster label Nov 27, 2024
@OCram85
Copy link
Author

OCram85 commented Nov 28, 2024

The CSS is still there:

  • desktop: app/out/vs/workbench/workbench.desktop.main.css
  • web: out/vs/workbench/workbench.web.main.css

Thanks for the help, I could fix my problems by adding the custom fonts in /lib/vscode/out/vs/code/browser/workbench/workbench.css

@bpasero bpasero closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Jan 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
info-needed Issue requires more information from poster
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bpasero @aeschli @OCram85