Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed GTK window (min-max-close) control icons/buttons #234430

Open
AmirAlfallal opened this issue Nov 22, 2024 · 4 comments
Open

Missed GTK window (min-max-close) control icons/buttons #234430

AmirAlfallal opened this issue Nov 22, 2024 · 4 comments
Assignees
Labels
electron Issues and items related to Electron linux Issues with VS Code on Linux titlebar VS Code main title bar issues under-discussion Issue is under discussion for relevance, priority, approach upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@AmirAlfallal
Copy link

Type: Feature Request

Window close, minimize and maximize buttons (icon shape) with the new look in VSCode Insider latest update on ubuntu24 - automatically changed from GTK window control icons appearance to windows system looking ones.

VS Code version: Code - Insiders 1.96.0-insider (69acde7, 2024-11-21T05:04:38.064Z)
OS version: Linux x64 6.8.0-49-generic
Modes:

![Image](https://github.com/user-attachments/assets/cdadf498-97bf-4064-8149-6edc946f9eb8)
@benibenj
Copy link
Contributor

Could you attach an image of the window control buttons? You should not be seeing the windows WCO but the ones for Linux.

@benibenj benibenj added info-needed Issue requires more information from poster titlebar VS Code main title bar issues labels Nov 25, 2024
@AmirAlfallal
Copy link
Author

Here you are @benibenj
Image

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron labels Nov 25, 2024
@bpasero bpasero added linux Issues with VS Code on Linux and removed info-needed Issue requires more information from poster labels Nov 25, 2024
@bpasero
Copy link
Member

bpasero commented Nov 25, 2024

@codebytere fyi, do we have control over how WCO is rendered and why it would look different here?

@deepak1556
Copy link
Collaborator

deepak1556 commented Nov 26, 2024

Yes we have control on the rendering, but the implementation today is borrowed from Chrome. We did not use GTK api to draw the controls for reasons mentioned in electron/electron#41840 (comment). PWA also share the same implementation, unless there is a strong reason to diverge from upstream I doubt this will change.

@deepak1556 deepak1556 added the under-discussion Issue is under discussion for relevance, priority, approach label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
electron Issues and items related to Electron linux Issues with VS Code on Linux titlebar VS Code main title bar issues under-discussion Issue is under discussion for relevance, priority, approach upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

4 participants