Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Syntax Coloring Scope #74382

Closed
andremacola opened this issue May 27, 2019 · 3 comments
Closed

Improve Syntax Coloring Scope #74382

andremacola opened this issue May 27, 2019 · 3 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug php PHP support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@andremacola
Copy link

54168483-781f5280-444d-11e9-8868-390dcc20b940

Copy and paste the code below. The brackets are with the wrong color

<?php if ($test) { ?>
	<p>Lorem ipsum dolor, sit amet consectetur adipisicing elit. Molestiae ipsam eius quos voluptate hic recusandae excepturi cum. Dolores vitae sunt optio assumenda soluta aliquam numquam voluptatum modi minima, labore illo.</p>
<?php } else { ?>
	<p>Lorem ipsum dolor, sit amet consectetur adipisicing elit. Molestiae ipsam eius quos voluptate hic recusandae excepturi cum. Dolores vitae sunt optio assumenda soluta aliquam numquam voluptatum modi minima, labore illo.</p>
<?php } ?>

54559784-1f0d6c80-49c1-11e9-8a34-b807e081b18e

54559671-d81f7700-49c0-11e9-8152-5d4f059ab28f

As you can see it provides us just a generic source.php meta.embedded.line.phpthat we can't target. This is sort of bug because the second curly bracket (the opening one) have a different scope.
@vscodebot vscodebot bot added the php PHP support issues label May 27, 2019
@roblourens roblourens added the bug Issue identified by VS Code Team member as probable bug label May 30, 2019
@roblourens roblourens added this to the Backlog milestone Oct 27, 2019
@rzhao271
Copy link
Contributor

rzhao271 commented Nov 6, 2020

Closing this issue because it seems to be fixed on the latest version of Insiders.
@andremacola feel free to reply if this issue still occurs for you after updating.

@rzhao271 rzhao271 closed this as completed Nov 6, 2020
@rzhao271 rzhao271 added the *not-reproducible Issue cannot be reproduced by VS Code Team member as described label Nov 6, 2020
@andremacola
Copy link
Author

@rzhao271 nope, the scope still wrong in 1.51.0-insiders. Some themes you can't notice the problem but if you show the TM Scope you see the problem.

@roblourens roblourens mentioned this issue Nov 7, 2020
Open
@roblourens
Copy link
Member

Filed upstream atom/language-php#402

@roblourens roblourens added upstream Issue identified as 'upstream' component related (exists outside of VS Code) and removed *not-reproducible Issue cannot be reproduced by VS Code Team member as described labels Nov 7, 2020
@roblourens roblourens removed this from the Backlog milestone Nov 7, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug php PHP support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@roblourens @andremacola @rzhao271