Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect syntax highlighting of PHP strings containing an SQL query #97703

Closed
MmAaXx500 opened this issue May 13, 2020 · 1 comment
Closed
Assignees
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@MmAaXx500
Copy link

  • VSCode Version: 1.45.0 and 1.46.0-insider (e88b8d3)
  • OS Version: Win 10 1909

Syntax highlighting around an array appended to an SQL query string is incorrect.
Note the dots and square brackets.

Steps to Reproduce:

  1. Paste this to a PHP file:
<?php
$wrong    = "SELECT * FROM '" . $var["foo"] . "'";
$expected = "select * from '" . $var["foo"] . "'";
?>

Does this issue occur when all extensions are disabled?: Yes

image

@alexr00
Copy link
Member

alexr00 commented May 14, 2020

Moved to owning repo: atom/language-php#392

@alexr00 alexr00 closed this as completed May 14, 2020
@alexr00 alexr00 added grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream labels May 14, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

2 participants