Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New package: iwalton3.plex-mpv-shim version 1.11.0 #192829

Merged
merged 3 commits into from
Nov 26, 2024
Merged

New package: iwalton3.plex-mpv-shim version 1.11.0 #192829

merged 3 commits into from
Nov 26, 2024
+64 −0

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Nov 21, 2024 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Manual validation

Image
Image

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 21, 2024
@Dragon1573
Copy link
Contributor Author

During installation testing, this application failed to install without user input. Did you forget to add Silent or SilentWithProgress switches?

This can also happen when a dependency is missing. You can test with https://github.com/microsoft/winget-pkgs#test-your-manifest.

Please investigate a fix and resubmit the Pull Request.

You may also try using the Windows Package Manager Manifest Creator to determine the proper installer type. If the installer type is MSIX, MSI, or a known installer technology like NullSoft, Inno, etc. the wingetcreate tool can detect them and the winget client will know what switches to pass. If it's a .exe installer of an unknown type, you will need to search to determine the proper switches for Silent and SilentWithProgress.

Template: msftbot/validationError/installation/unattended

Unable to reproduce the problem in Windows Sandbox instance. It might be cause by an incorrect "architecture detection" from Komac.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 21, 2024
@Dragon1573
Update manifest: iwalton3.plex-mpv-shim version 1.11.0
a234999 
- Switch architecture of the installer
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. labels Nov 21, 2024
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 21, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 21, 2024
@Dragon1573
Copy link
Contributor Author

Can't determine what was wrong. Everything works fine in Windows Sandbox.

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 22, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 23, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

(Automated response - build 899.)

@stephengillie
Copy link
Collaborator

Hi @Dragon1573,

Manual Validation ended with:
image

Should Plex.PlexMediaServer or a similar package be a dependency?

Verify:
image

@stephengillie stephengillie added Needs-Author-Feedback This needs a response from the author. and removed Needs-Attention This work item needs to be reviewed by a member of the core team. labels Nov 26, 2024
@Dragon1573
Copy link
Contributor Author

Manual validate on the physical device again. Nothing wrong with it.

11:10:57 D:\...\winget-pkgs  [issues/192489 ≡] 124ms 0x80070003 pwsh> winget install -m .\manifests\i\iwalton3\plex-mpv-shim\1.11.0\ -l D:\Applications\iwalton3\plex-mpv-shim\
已找到 Plex MPV Shim [iwalton3.plex-mpv-shim] 版本 1.11.0
此应用程序由其所有者授权给你。
Microsoft 对第三方程序包概不负责，也不向第三方程序包授予任何许可证。
正在下载 https://github.com/iwalton3/plex-mpv-shim/releases/download/v1.11.0/plex-mpv-shim_1.11.0_installer.exe
  ██████████████████████████████  38.3 MB / 38.3 MB
已成功验证安装程序哈希
正在启动程序包安装...
安装程序将请求以管理员身份运行，需要提示。
已成功安装

image
image

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 26, 2024
@Dragon1573
Update manifest: iwalton3.plex-mpv-shim version 1.11.0
1561c58 
- Add "Plex.PlexMediaServer" as a package dependency.

Signed-off-by: Dragon1573 <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Moderator-Approved One of the Moderators has reviewed and approved this PR labels Nov 26, 2024
@wingetbot wingetbot added the Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. label Nov 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Nov 26, 2024
@Dragon1573
Copy link
Contributor Author

Duplicate case of #192829 (comment).

CC @stephengillie 😕

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Nov 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Nov 26, 2024
@stephengillie stephengillie added Validation-Completed Validation passed and removed Validation-Unattended-Failed During installation testing the installer was blocked on user input and no switches were provided. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Nov 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 5799fd1 into microsoft:master Nov 26, 2024
1 of 2 checks passed
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

@ItzLevvie ItzLevvie ItzLevvie approved these changes

Assignees

@Dragon1573 Dragon1573

@stephengillie stephengillie

Labels
Moderator-Approved One of the Moderators has reviewed and approved this PR Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: plex-mpv-shim
4 participants
@Dragon1573 @wingetbot @stephengillie @ItzLevvie