Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][mgt-chat] HTML tags visible after editing chat within MGT mgt-chat component #3155

Open
Laurence-V opened this issue Apr 3, 2024 · 3 comments
Labels
bug Something isn't working Components: mgt-chat Mgt chat related issues Priority: 1

Comments

@Laurence-V
Copy link

Laurence-V commented Apr 3, 2024

Describe the bug
When editing in the mgt-chat component of MGT, the client renders HTML tags, these then persist on web/fat client if changes are made and saved. The HTML tags are not rendered in the mgt-chat component on saving.

To Reproduce
Steps to reproduce the behavior in MGT:

  1. Go to a system running chats using MGT
  2. Click on a message you have sent to get the context menu and select Edit
  3. The message will become editable
  4. Error: The message now shows the HTML tags, while in Edit Mode

To see in Web/Fat client

  1. Make a change while in the MGT chat component, while in Edit Mode
  2. Accept change
  3. Go message to Web/Fat client
  4. Error: The message now shows the HTML tags

Expected behavior
HTML tags should not be visible in the clients

Screenshots
In Edit Mode in MGT Chat Component:
Screenshot 2024-04-03 at 14 15 05
In fat client (not edit mode):
Screenshot 2024-04-03 at 14 15 28
In web client (not edit mode):
Screenshot 2024-04-03 at 14 14 45

Environment (please complete the following information):

  • Client OS: Mac Sonoma 14.4
  • Browser: Chrome Version 123.0.6312.86 (Official Build) (arm64)
  • Framework: React
  • Context: Microsoft Teams Graph Toolkit
  • Version 4
@Laurence-V Laurence-V added bug Something isn't working Needs: Triage 🔍 labels Apr 3, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Graph Toolkit Apr 3, 2024
@musale
Copy link
Contributor

musale commented May 14, 2024

@Laurence-V this is a valid bug. I'm moving it to our backlog and it'll be fixed as soon as possible

@musale musale added Priority: 1 Components: mgt-chat Mgt chat related issues and removed Needs: Triage 🔍 labels May 14, 2024
@Laurence-V
Copy link
Author

Laurence-V commented May 14, 2024

Thanks @musale,
I've also noticed that in the MGT component, Less Than and Greater Than get converted into HTML
And that HTML Tags get rendered correctly i.e. with <> but they also get auto completed in the MGT component
Whereas in the (New) Teams client, they are rendered as entered.

Messages entered from Microsoft Graph Toolkit
MGT_Component

Messages displayed in Teams Client
TeamClient

@musale
Copy link
Contributor

musale commented May 14, 2024

@Laurence-V the processing of the Teams messages in mgt-chat is done by parsing the html text so I would suggest that these edge cases are given an independent look. Could you make this another issue so that we can track other scenarios too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Components: mgt-chat Mgt chat related issues Priority: 1
Projects
Status: Needs Triage 🔍
Development

No branches or pull requests

2 participants