Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Iterator Task - Design improvements #37

Open
nikithauc opened this issue Sep 8, 2020 · 2 comments
Open

Page Iterator Task - Design improvements #37

nikithauc opened this issue Sep 8, 2020 · 2 comments

Comments

@nikithauc
Copy link
Contributor

nikithauc commented Sep 8, 2020

Please check the links below
Example
Suggestion

@nikithauc
Copy link
Contributor Author

Adding to this -
microsoftgraph/msgraph-sdk-serviceissues#38
Currently, the PageIterator works with the value and the @odata.nextLink and the other meta data is not considered. How can the other metadata that is returned in the response be handled in a better way?

@MIchaelMainer
Copy link
Contributor

MIchaelMainer commented Dec 9, 2020

I take blame for this. I know better than hiding the entire response envelope. We should consider expanding the PageCollection interface to represent the entire response envelope so that response headers can be accessed. It already has an additional property which should hold all of the other properties not in value and not in the odata.nextlink and odata.deltalink properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants