Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme Maker Bugs #365

Open
omodia opened this issue Mar 2, 2024 · 1 comment
Open

Theme Maker Bugs #365

omodia opened this issue Mar 2, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@omodia
Copy link

omodia commented Mar 2, 2024

Type of installation

Portable (.zip)

Type of reader (if reader related)

None

Steps to reproduce

Same problem in all readers (epub, html, image).

1. Reader Settings

  • Its 3 values in themes is not reflecting changes.
  • Reader settings toggle icon is linked to text color instead of icon color.

2. Side List Pin Icon

  • It is not linked to icon color in theme maker.
  • Pin icon and locate current chapter icon is linked to text color and not icon color.

3. Top Bar

  • Chapter name in top bar is linked to icon color instead of text color.

4. Reader side list main divider

  • It is not linked to reader side list divider color in theme maker.

5. Toggle Color

  • The toggle color is not changing when using icon color.

✔️ Expected Behavior

  1. Reader settings 3 values to work and its toggle icon to be linked to icon color.
  2. Side list pin and locate chapter icon to be linked to icon color.
  3. Top bar chapter name to be linked to text color.
  4. Reader side list divider to be linked to reader side list divider color.
  5. The toggle color should be linked to icon color.

❌ Actual Behavior

Opposite of expected behaviour.

@omodia omodia added the bug Something isn't working label Mar 2, 2024
@github-project-automation github-project-automation bot moved this to For Review in yomikiru todo Mar 2, 2024
@omodia
Copy link
Author

omodia commented Mar 2, 2024

✔️ Expected Behavior

  1. Reader settings 3 values to work and its toggle icon to be linked to icon color.
  2. Side list pin and locate chapter icon to be linked to icon color.
  3. Top bar chapter name to be linked to text color.
  4. Reader side list divider to be linked to reader side list divider color.
  5. The toggle color should be linked to icon color.

I checked all, and only the above 5 properties are not working as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: For Review
Development

No branches or pull requests

1 participant