LosslessCut-linux-x64.tar.bz2 is shipped without the program's icon.svg

[AnthillSudoku]

The fewer issues I have to read, the more new features I will have time to implement, so I ask that you please try these things first

• Check out all the menus and keyboard shortcuts. Maybe the feature already exists?
• Try with the newest version from GitHub
• Read the documentation and FAQ, Known issues, Troubleshooting to see if the feature already exists
• See if someone already suggested this under Issues or Discussions

Description

LosslessCut icon is available at icon.svg, but LosslessCut-linux-x64.tar.bz2at releases does not include it.

It would be nice to have it inside the bz2 file, so users can easily make a *.desktop launcher with the icon

Thanks for the app

[mifi]

how would users easily make a .desktop launcher with the icon? can't they just download it here from github?

[AnthillSudoku]

They first have to find that the icon is in the repository and where it is. If a user download a program, why the icon is not included?
It's not a external plugin, it's the main icon, and LosslessCut is not a program that runs on terminal.

Do the windows or mac version not provides an icon with the program installer?

[mifi]

The icon should already be included here:

lossless-cut/package.json

Line 432 in e819bce

"icon": "icon-build/app-512.png",

I don’t know how else to expose it.

[AnthillSudoku]

That's the source code, not the releases.

I am speaking about LosslessCut-linux-arm64.tar.bz2 (as stated in the first message).

There is no icon in there

[mifi]

Oh, could be a bug in electron builder then, or a misconfiguration. Is it the same with appimage/snap?

[AnthillSudoku]

appimage

if I extract the appimage version:

./LosslessCut-linux-x86_64.AppImage --appimage-extract

in the main folder there is losslesscut.png, it's a link that point to

usr/share/icons/hicolor/0x0/apps/losslesscut.png

snap

sorry, I have never used snap, so I have no idea

[mifi]

So it means that the configuration here is correct because the icon does get included in the appimage:

lossless-cut/package.json

Line 432 in e819bce

"icon": "icon-build/app-512.png",

unfortunately it's not clear to me how to include the icon for the tar.bz2 package, as I cannot find an electron-builder option for that. so i'm going to close this but feel free to suggest how or create a PR for it.

somewhat related: electron-userland/electron-builder#5294 and #2237

[AnthillSudoku]

Could the icon's section at Electron Builder manual help you?

https://www.electron.build/icons

[mifi]

as i've alreeady set icon to icon-build/app-512.png, for linux (see above) I don't know what else to do.
the icon is being auto generated at build time:

lossless-cut/script/icon-gen.mts

Line 17 in e819bce

await svg2png(srcIcon, './icon-build/app-512.png', 512, 512);