Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There might be a small problem with the delete flow when one removed object and later set flag #118

Open
mpryc opened this issue Nov 22, 2024 · 1 comment
Assignees

Comments

@mpryc
Copy link
Collaborator

mpryc commented Nov 22, 2024

Review the scenario which may lead to the objects not being properly cleaned up:

  1. Create NonAdminBackup
  2. Wait until Velero Backup is created and check if Finalizer is set on the NonAdminBackup
  3. Remove NonAdminBackup object by invoking oc delete
  4. Set the delete flag on the NonAdminBackup object

Expected:

  • The delete flag should kick in the velero deletion workflow as it takes precedence over oc delete, which may not be the case at the moment (need to investigate that workflow)

This behavior was seen during development of another feature, that's why it requires testing.

@mpryc mpryc self-assigned this Nov 22, 2024
@shubham-pampattiwar
Copy link
Member

Need to set the expectations here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants