Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider simplifying logic in reconcile loop for NAB. #62

Closed
mpryc opened this issue May 8, 2024 · 1 comment · Fixed by #97
Closed

Consider simplifying logic in reconcile loop for NAB. #62

mpryc opened this issue May 8, 2024 · 1 comment · Fixed by #97
Assignees

Comments

@mpryc
Copy link
Collaborator

mpryc commented May 8, 2024

          Alright, what about keeping as it is, but simplify `if`s :question: 
	if reconcileExit || reconcileRequeue || reconcileErr != nil{
		return ctrl.Result{Requeue: reconcileRequeue, RequeueAfter: requeueTimeSeconds * time.Second}, reconcileErr
	}

Originally posted by @mateusoliveira43 in #54 (comment)

@mateusoliveira43
Copy link
Contributor

mateusoliveira43 commented Sep 11, 2024

Another places we need to change after today's discussion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Merged / Ready for build
Development

Successfully merging a pull request may close this issue.

3 participants