-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mLastStableState was not set on setState #43
Comments
I encountered the same issue and the change proposed by @cesardeazevedo solved the problem. I did not notice any negative side effects so far. |
ok, so I think we can close this issue right? |
The fix works, yes. But it is not part of this repository, is it? |
I think this should be definitely part of this repository, i just didn't created a pull request earlier because i wasn't sure of any side effects, but i haven't seen so far. @michael-rapp would you mind to create a pull request? |
I have created a pull request (#59) including the changes I used to solve this issue. My solution is slightly different from the one suggested by @cesardeazevedo as I think that the variables |
Fix for issue #43 "mLastStableState was not set on setState"
Hi, thank you so much for this project.
I had a issue when setting state directly with setState, and it seems the mLastStableState was not set on this line: https://github.com/miguelhincapie/CustomBottomSheetBehavior/blob/master/app/src/main/java/co/com/parsoniisolutions/custombottomsheetbehavior/lib/BottomSheetBehaviorGoogleMapsLike.java#L563
What happens is when we set the state directly from expand to collapse, and starting dragging again, the bottom sheet makes a "hard jump" expanding like crazy, this happens on the sample project when we press the navigation close icon.
I've solved by moving the assignment out of the
if (mViewRef == null)
statement, but i'm still not sure about that, i just would like to point that, and hear this from you, and others who having this issue.i am currently integrating this awesome project with react-native (react-native-bottom-sheet-behavior), but this isn't related though.
Thank you.
The text was updated successfully, but these errors were encountered: