Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a size slider for the List Display Mode #1687

Open
4 tasks done
MavikBow opened this issue Jan 31, 2025 · 3 comments · May be fixed by #1688
Open
4 tasks done

Add a size slider for the List Display Mode #1687

MavikBow opened this issue Jan 31, 2025 · 3 comments · May be fixed by #1688
Labels
Feature request New feature or request

Comments

@MavikBow
Copy link

MavikBow commented Jan 31, 2025

Describe your suggested feature

I've already done the same PR to the aniyomi fork, here's how it looks with images. I don't personally use mihon, but I don't mind adding the same feature here 'cause I really lacked it in the fork. Maybe mihon users would also appreciate it.

Ideally I would've liked to wait until it was approved in aniyomi before suggesting here, but there's no telling how long this is gonna take.

Pros of this change:

  • being able to scale the list (duh)
  • the long full names of mangas can fit, if upscaled enough
  • visual change to match the grids (that's optional ofc, but it does look better like this imho).

My main question is: Is this a good suggestion? Would you guys want it here?

Other details

Update: my aniyomi PR has been approved, which means this one is next. I won't take long.

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have updated the app to version 0.17.1.
  • I will fill out all of the requested information in this form.
@MavikBow MavikBow added the Feature request New feature or request label Jan 31, 2025
@MajorTanya
Copy link
Member

I see you seemingly chose the values of the slider based on how many entries it would fit on screen, judging by a quick glance at the screenshots. As someone with a zoomed out and scaled down phone UI (so everything is smaller), would that make Mihon just make the entry rows that much larger?

@MavikBow
Copy link
Author

MavikBow commented Jan 31, 2025

would that make Mihon just make the entry rows that much larger?

I'm not exactly sure what you mean here. But the number of entries should in theory stay the same regardless of your phone UI settings. However I'd assume the text would indeed appear smaller, but it already appears smaller to you, so that's not a change. The slider goes up to 10 (and we can always up that number), is that still too big for your liking?

The grids already scale based on a set number, how does that work for you?

Edit: after some testing on my device, yes, things work as I said. However, if people like you prefer how the list looked super tiny, maybe I'll set the default size to match the current non-numbered approach instead of making it 7. But that's exactly why I'm asking for feedback here.

@MajorTanya
Copy link
Member

I guess I misunderstood something when looking at those screenshots 🤔 not sure what confused me there, apologies.

@MavikBow MavikBow linked a pull request Jan 31, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants