Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lost of sidebar dot #1788

Open
6 tasks done
Octoton opened this issue Feb 27, 2025 · 6 comments
Open
6 tasks done

Lost of sidebar dot #1788

Octoton opened this issue Feb 27, 2025 · 6 comments
Labels
Bug Something isn't working

Comments

@Octoton
Copy link

Octoton commented Feb 27, 2025

Steps to reproduce

Open mihon
Try changing the grid side or just open a chapter and try changer page with the bottom slide bar

Expected behavior

There should be dot to indicat where a new page is or what grid size are available

Actual behavior

The slide bar has no dot expect at the far end

Crash logs

No response

Mihon version

App version: 0.17.1-7113 (cd04815, 10, 2025-02-27T19:08:56Z) Android version: 15 (SDK 35; build lineage_sunfish-userdebug 15 AP4A.250205.002 ab3fc6b36a) Device brand: google Device manufacturer: Google Device name: sunfish (sunfish) Device model: Pixel 4a WebView: Android System WebView 132.0.6834.122 Current time: 2025-02-27T23:55:56.609557+01:00

Android version

android 15

Device

pixel 4a

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open or closed issue.
  • I have written a short but informative title.
  • I have gone through the FAQ and troubleshooting guide.
  • I have updated the app to version 0.17.1.
  • I have updated all installed extensions.
  • I will fill out all of the requested information in this form.
@Octoton Octoton added the Bug Something isn't working label Feb 27, 2025
@MajorTanya
Copy link
Member

Is this about the step indicators in sliders?

@Octoton Octoton changed the title Lost of soidebar dot Lost of sidebar dot Feb 27, 2025
@Octoton
Copy link
Author

Octoton commented Feb 27, 2025

Yes

@MajorTanya
Copy link
Member

I believe the steps in the chapter page slider were removed intentionally. However, you said they're also missing in the grid size adjustment slider? What theme are you using and could you provide a screenshot?

@Octoton
Copy link
Author

Octoton commented Feb 27, 2025

Tried multiple theme and all of them had this problem, see screenshot with dynalic theme :

Image

@Octoton
Copy link
Author

Octoton commented Feb 27, 2025

In chapter the dot where usefull has it help click exactly where we wanted to and get a sens of how many page they where
If it was intentionnal, why keep a lonely dot at the end ?

@MajorTanya
Copy link
Member

MajorTanya commented Feb 27, 2025

get a sens of how many page they where

Both the current page number and the last page number are displayed next to the slider (which end is what number depends on your reading direction).

If it was intentionnal, why keep a lonely dot at the end ?

Because the final dot is not controlled by us, it's controlled by the internals of the Slider component directly and serves as the "this is the end" value indicator.

Tried multiple theme and all of them had this problem, see screenshot with dynalic theme :

Thank you, we'll look into what we can do about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants