New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse_decimal mixes signed/unsigned... #12

Open

nickds1 opened this issue Aug 21, 2017 · 0 comments

nickds1 commented Aug 21, 2017 •

edited

Loading

The parse_decimal method is defined "unsigned long" yet it parses and attempts to return a signed number.

This means that it will not handle negative numbers correctly and return erroneous results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment