Skip to content
This repository has been archived by the owner on Oct 17, 2022. It is now read-only.

option to show other markers #30

Open
Dontorpedo opened this issue Nov 2, 2019 · 4 comments
Open

option to show other markers #30

Dontorpedo opened this issue Nov 2, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Dontorpedo
Copy link

Dontorpedo commented Nov 2, 2019

Hi, a option to show other markers / or all on the detailpage would be nice.. or maybe only nearby..

thanks
Denis

@mikebronner
Copy link
Owner

Hi @Dontorpedo thanks for submitting that idea. However, for now I think I will leave that feature out, because it doesn't really match with the intended purpose of this package. Could you expand on why this feature is important to your use-case?

@mikebronner mikebronner self-assigned this Nov 2, 2019
@mikebronner mikebronner added the question Further information is requested label Nov 2, 2019
@Dontorpedo
Copy link
Author

Hi, yes!

it would be very helpfull for winter service tour planning, and services that are charged depending how many customers are nearby

@mikebronner
Copy link
Owner

mikebronner commented Sep 4, 2020

@Dontorpedo Thanks for following up. For that to be programmatically useful though, I would think you would need to have more information returned than just the coordinates of the marker. For example, you would need the coordinates of the nearby markers, perhaps with distance and direction from the original marker, to be able to use it in any significant way.

Further, how would you determine which markers to show? Would they need to be based on specific criteria, distance, attributes, etc.? All these things are beyond what this Nova field is designed for.

This field is intended solely for determining lat/long coordinates of a given point on the map.

For more complex things, it is probably better to create your own custom field with the specific functionality you need, or perhaps even not do it in Nova, but have it be first-citizen functionality of your app.

I'm only guessing, of course, based on your short description -- it's difficult for me to envision exactly what your intentions are.

@mikebronner
Copy link
Owner

I can see what you mean by showing other markers nearby on the detail screen to give context, though.

If we limited it to nearby markers, we would have to have GIS functionality in the database to calculate distance in the where clauses. If we loaded all markers, it could quickly crash the page.

I'm going to put this on hold for now, but keep it here in case I can think of a good way to implement it. I'll be happy to consider a PR if you want to submit one and it is performant :).

@mikebronner mikebronner added enhancement New feature or request wontfix This will not be worked on and removed question Further information is requested wontfix This will not be worked on labels Sep 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants