Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

githubsearch: remove cookie serialization of saved searches, set html "title" element for bookmarks instead #24

Open
rmuir opened this issue Feb 19, 2024 · 1 comment

Comments

@rmuir
Copy link
Collaborator

rmuir commented Feb 19, 2024

The saved searches are a bit wonky as they are serialized in cookie and will overflow cookie maximums quickly.

Instead, just suggest the user use bookmarks (e.g. hit ^D) to save searches? they already work, just aren't very usable because <title> isn't being set. If you search on "OOME", maybe we should just set <title>githubsearch: OOME</title> so that it has a nice "name" in your bookmarks when you add it.

@mikemccand
Copy link
Owner

Also, the cookies do not survive browser restart ;) They are apparently merely "session cookies" now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants