Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy fails when using secrets in task definition #11

Open
ChristophP opened this issue Jun 18, 2019 · 1 comment · May be fixed by #10
Open

Deploy fails when using secrets in task definition #11

ChristophP opened this issue Jun 18, 2019 · 1 comment · May be fixed by #10

Comments

@ChristophP
Copy link

ChristophP commented Jun 18, 2019

ECS has a feature where it is possible to populate env variables from the ssm parameter store.
The task definition the looks kinda like this. https://docs.aws.amazon.com/AmazonECS/latest/developerguide/specifying-sensitive-data.html

{
  "containerDefinitions": [{
    "secrets": [{
      "name": "environment_variable_name",
      "valueFrom": "arn:aws:ssm:region:aws_account_id:parameter/parameter_name"
    }]
  }]
}

In order for secrets to work the property "executionRoleArn" must be set in the task definition but unfortately that property is not preserved by this script.

I opened a pull request to fix this. Would be great if it could be merged in since our deployments rely on this package. Thanks for making it <3

@jpcbarros
Copy link

+1 please merge the PR as I need this too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants