Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_bindings.slice() in dispatch() method may not work as intended since slice() returns a shallow copy. #73

Open
neochang opened this issue Dec 21, 2017 · 0 comments
Open

_bindings.slice() in dispatch() method may not work as intended since slice() returns a shallow copy. #73

neochang opened this issue Dec 21, 2017 · 0 comments

Comments

@neochang
Copy link

In Signal.prototype.dispatch() method, there is the following line along with the comment:

bindings = this._bindings.slice(); //clone array in case add/remove items during dispatch

but since Array.slice() method returns a shallow copy, does that really work?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@neochang