Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Labels params added #13

Closed
wants to merge 3 commits into from
Closed

Labels params added #13

wants to merge 3 commits into from

Conversation

JennLeon
Copy link

@JennLeon JennLeon commented Sep 12, 2022 •
edited
Loading

Labels params added

Related issue

@mariux

@JennLeon JennLeon requested review from mariux and a team as code owners September 12, 2022 13:50
soerenmartius
soerenmartius approved these changes Sep 12, 2022
View reviewed changes
Copy link
Member

@soerenmartius soerenmartius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for providing this fix. I will create a new release in a little while

@mariux
Copy link
Member

mariux commented Sep 12, 2022

we need to update the test suite ;) @waxb will try to do so..

@JennLeon
Copy link
Author

Hey @mineiros-team @mariux @waxb hope is all good, i wanna understand whats missing for this PR?

@mariux
Copy link
Member

mariux commented Sep 22, 2022

cont. in #18 to make tests run r4r ;)

@mariux mariux closed this Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soerenmartius soerenmartius soerenmartius approved these changes

@mariux mariux Awaiting requested review from mariux mariux is a code owner

Assignees

@waxb waxb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JennLeon @mariux @soerenmartius @waxb