Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MZTimerLabel memory error!!! #89

Open
semnyqu opened this issue Feb 8, 2018 · 3 comments
Open

MZTimerLabel memory error!!! #89

semnyqu opened this issue Feb 8, 2018 · 3 comments

Comments

@semnyqu
Copy link

semnyqu commented Feb 8, 2018

Use MZTimerLabel in UITableViewCell, cannot release!
default

default

@semnyqu
Copy link
Author

semnyqu commented Feb 8, 2018

/Target label obejct, default self if you do not initWithLabel nor set/
@Property (nonatomic,strong) UILabel *timeLabel;

Very strange design

@SBourgon
Copy link

The project I'm on uses a fork of this, but I had just found this leak also.
I had just fixed this myself by having the property getter for timeLabel return self, rather then assign self.

- (UILabel*)timeLabel
{
    if (_timeLabel == nil) {
//_timerLabel = self
        return self;
    }
    return _timeLabel;
}

@Richard1900
Copy link

/Target label obejct, default self if you do not initWithLabel nor set/ @Property (nonatomic,strong) UILabel *timeLabel;

Very strange design

Very bad design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants