This repository has been archived by the owner on May 13, 2024. It is now read-only.
Update minimum CMake version #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This depends on #272 |
|
What for? Are we missing any features? |
|
We are missing the ability to add link libraries to object library targets. We'd like this for the glTF development, and I'd like it for the Irrlicht CMakeLists as well to help clean it up. |
|
ok in that case:
verdict: we can do this |
|
yay |
sfan5
reviewed
Jan 5, 2024
|
Do we have to do anything else? |
|
JosiahWI
added a commit
to JosiahWI/irrlicht
that referenced
this pull request
Jan 20, 2024
The minimum CMake version was updated to 3.12 in minetest#270. This cleans up the build using the feature to use target_link_libraries on object library targets that was added in CMake 3.12. It has been tested on Linux with OpenGL. I will test it with more settings and on more systems as the work progresses.
JosiahWI
added a commit
to JosiahWI/irrlicht
that referenced
this pull request
Jan 20, 2024
The minimum CMake version was updated to 3.12 in minetest#270. This cleans up the build using the feature to use target_link_libraries on object library targets that was added in CMake 3.12. It has been tested on Linux with OpenGL. I will test it with more settings and on more systems as the work progresses.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cmake in engine currently very old.
Give it a few birthdays so we can use newer features.
We are missing the ability to add link libraries to object library targets. We'd like this for the glTF development.