Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide direct download links to all Android APK architectures #281

Merged
merged 4 commits into from
Oct 15, 2024

Conversation

rollerozxa
Copy link
Member

Rather than just providing a link to the ARM 32-bit APK like that is all that's available.

@sfan5
Copy link
Member

sfan5 commented May 17, 2023

I was under the impression that we don't do this because the arm64-v8a APK has some unsolved problems.

@rollerozxa
Copy link
Member Author

minetest/minetest#9107, I assume? Unsure if it still occurs, haven't experienced it myself.

Google Play and F-Droid already distributes arm64 binaries to all 64-bit phones, and the 64-bit version obviously performs better too (assumedly also uses GC64). So I'm unsure if there's much purpose to hiding direct downloads for it.

@sfan5
Copy link
Member

sfan5 commented Sep 17, 2023

minetest/minetest#9107, I assume?

yes

the 64-bit version obviously performs better too (assumedly also uses GC64).

in theory yes
in practice if the loading screen is stuck making barely any progress for a minute you lose 30% of players (made up figure). it doesn't matter how great the game performs to players who don't make it there.

@sfan5
Copy link
Member

sfan5 commented Oct 8, 2024

Please rebase, this issue has been adressed as of minetest/minetest#14288

@rollerozxa
Copy link
Member Author

Please rebase, this issue has been adressed as of minetest/minetest#14288

I hope so considering a direct download link to the ARM64 apk was already linked on the download page in the time after I had opened this PR. x) But this PR also adds download links to the x86 and x86_64 apks, so this PR is still relevant.

downloads.html Outdated Show resolved Hide resolved
@sfan5 sfan5 merged commit 2a2c9bf into minetest:master Oct 15, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants