-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add module-info.java #4
Comments
Are you averse to using a higher version of gradle? Like gradle 5.5? |
No I think we are not against using a newer version. I think it is just that nobody up to now took the time to try and see what are the impacts (e.g. on the builds, the release mechanism etc....) |
I kinda got started here: https://github.com/smac89/minifx-workbench/tree/java-11 I was also reading something about modules and stumbled across this concept of a multi-release jar, which you may find interesting: |
Dear @smac89, thanks for getting started on this! I will try to take a look ... Do you understand why the one test is failing? As we mentioned in the pull request, the multi-version jar will not help us, as we need different transient deps for different jdks. |
I'm not sure, but it might be an issue with Spring. |
Looks like it works now. I didn't push anything yet to my branch I replaced the default task springTesting(type: Test, group: test.group) {
testLogging {
events "passed", "skipped", "failed"
exceptionFormat "full"
}
} Running this new test passes Not sure what the default test is doing tbh |
As we target java11 now, it would be good to have module support also implemented.
The text was updated successfully, but these errors were encountered: