Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated 8.1 #5

Open
ticariofis opened this issue Jan 23, 2023 · 2 comments · May be fixed by #6
Open

Deprecated 8.1 #5

ticariofis opened this issue Jan 23, 2023 · 2 comments · May be fixed by #6

Comments

@ticariofis
Copy link

Hello;

I am getting such an error.

can you help me ?

Deprecated: Return type of Minwork\Helper\ArrObj::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in/libraries/minwork/ArrObj.php on line 299

Deprecated: Return type of Minwork\Helper\ArrObj::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /libraries/minwork/ArrObj.php on line 277

Deprecated: Return type of Minwork\Helper\ArrObj::offsetGet($offset) should either be compatible with ArrayAccess::offsetGet(mixed $offset): mixed, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /libraries/minwork/ArrObj.php on line 282

Deprecated: Return type of Minwork\Helper\ArrObj::offsetSet($offset, $value) should either be compatible with ArrayAccess::offsetSet(mixed $offset, mixed $value): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /libraries/minwork/ArrObj.php on line 287

Deprecated: Return type of Minwork\Helper\ArrObj::offsetUnset($offset) should either be compatible with ArrayAccess::offsetUnset(mixed $offset): void, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in //libraries/minwork/ArrObj.php on line 292

Deprecated: Return type of Minwork\Helper\ArrObj::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /libraries/minwork/ArrObj.php on line 304
@minwork minwork linked a pull request Jan 24, 2023 that will close this issue
fix(build): Deprecation issues in PHP 8.1 #6
Open
@minwork
Copy link
Owner

minwork commented Jan 24, 2023

Hey, I've tried to resolve this issue by adjusting types in ArrObj but it requires more work to bring back tests to live and at the same time make everything backward compatible to at least PHP 7.3.

If you like you can further work on it in #6.

I am no longer using PHP so I won't be able to spend more time fixing that, but any contribution in solving this problem is welcome and will be merged as long as it make all tests pass.

@ticariofis
Copy link
Author

thank u very much..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): Deprecation issues in PHP 8.1 minwork/array
2 participants
@ticariofis @minwork