Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASSETS_DEBUG should fallback to Django DEBUG by default #84

Closed
IlyaSemenov opened this issue Aug 11, 2016 · 2 comments
Closed

ASSETS_DEBUG should fallback to Django DEBUG by default #84

IlyaSemenov opened this issue Aug 11, 2016 · 2 comments

Comments

@IlyaSemenov
Copy link
Contributor

Steps to reproduce

  1. Set DEBUG = True, do not set ASSETS_DEBUG
  2. Do not run manage.py collectstatic
  3. Add this to template: {% assets "admin/js/vendor/jquery/jquery.js", output="jquery.js" %}{% endassets %}
  4. django-assets will crash with BundleError (file does not exist)
  5. Set ASSETS_DEBUG = True
  6. Everything will work fine.

Expected

Step 4. Everything works fine.

In other words, if ASSETS_DEBUG is not set explicitly, django-assets should follow Django DEBUG setting (and use staticfiles finders). Right now we are forced to change these settings simultaneously.

@IlyaSemenov
Copy link
Contributor Author

#62 is referring the same issue, actually.

@IlyaSemenov
Copy link
Contributor Author

and #67 provides the PR... 🤦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant